newscorp-ghfb / NewsKit

The NewsKit Design system
https://newskit.co.uk
Other
129 stars 13 forks source link

Update Radio button component scenarios - Storybook #741

Closed jps closed 1 year ago

jps commented 1 year ago

Description

Updates to the Radio button component scenarios- Storybook

Tasks/Steps

Notes (main differences to what we have currently live versus the designs)

Acceptance/Testing Criteria

Given I am in Storybook When I view the Radio button component pages Then the pages will be updated as per the designs And the pages will be within 1024x768 for Applitools snapshots.

Business Benefit/Value

Consistent Radio button examples for consumers, aligning to the NK branding.

Supporting Information

Designs: NewsKit - Storybook Project - Feedback and Status

Dependencies

N/A

Review with design when ready.

mutebg commented 1 year ago

@GeriReid @nathanparris http://ncu-newskit-docs-pr.s3-website-eu-west-1.amazonaws.com/741-update-radio-button-component-scenarios-storybook/storybook/?path=/docs/components-radio-button--story-radio-button-default

nathanparris commented 1 year ago

@mutebg Couple of notes from me

Default story

Size story

GeriReid commented 1 year ago

Thanks @mutebg, just one further spot from me:

Docs page: could you add the title at the top and link to the docs site. Text: Radio buttons are selection controls that are typically used in forms. Link: https://www.newskit.co.uk/components/radio-button/

image

Thanks

mutebg commented 1 year ago

Thank you @GeriReid & @nathanparris I did update the stories accordingly

GeriReid commented 1 year ago

Thanks for making these edits @mutebg, you can move this one to review.