feat(898): Select panel position - Githubissues

newscorp-ghfb / NewsKit

The NewsKit Design system

https://newskit.co.uk

Other

130 stars 14 forks source link

feat(898): Select panel position #899

Closed pdimova closed 1 year ago

pdimova commented 1 year ago

What

https://github.com/newscorp-ghfb/NewsKit/assets/16742525/dfe693e9-3443-40e0-a622-9808de43ddf4

https://github.com/newscorp-ghfb/NewsKit/assets/16742525/819306a8-9ac4-4393-a7ae-7b8e04d8d61e

Background - why this is needed
What did you do
What does the reviewers should expect

I have done:

[ ] Written unit tests against changes
[ ] Written functional tests against the component and/or NewsKit site
[ ] Updated relevant documentation

I have tested manually:

[ ] The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
[ ] The screen reader reads and flows through the elements as expected.
[ ] There are no new errors in the browser console coming from this PR.
[ ] When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
[ ] The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

pp-serviceaccount commented 1 year ago

You can preview these changes on: Documentation Site: http://ncu-newskit-docs-pr.s3-website-eu-west-1.amazonaws.com/898-select-panel-position Storybook: http://ncu-newskit-docs-pr.s3-website-eu-west-1.amazonaws.com/898-select-panel-position/storybook