feat/905-fontMetrics-for-djds-themes-publisher-format - Githubissues

newscorp-ghfb / NewsKit

The NewsKit Design system

https://newskit.co.uk

Other

130 stars 14 forks source link

feat/905-fontMetrics-for-djds-themes-publisher-format #906

Closed dj-kmuldoon closed 1 year ago

dj-kmuldoon commented 1 year ago

Supports both current NewsKit parsing of fontMetrics and pre-parsed fontMetrics in typographyPreset for djds-themes-publisher

What

Background - why this is needed
What did you do
What does the reviewers should expect

I have done:

[Y] Written unit tests against changes
[N] Written functional tests against the component and/or NewsKit site
[N] Updated relevant documentation

I have tested manually: // // Changes are foundational rather than component specific... //

[N] The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
[N] The screen reader reads and flows through the elements as expected.
[N] There are no new errors in the browser console coming from this PR.
[N] When a visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
[N] The Playground feature is working as expected

dj-kmuldoon commented 1 year ago

LGTM, can you please create a new branch feat/905-fontMetrics-for-djds-themes-publisher-format so that CI can be triggered

I changed the name of the current branch in GitHub to 'feat/905-fontMetrics-for-djds-themes-publisher-format'. Let me know if that unblocks all!