feat(TMR-1285): nonce prop to Tealium component - Githubissues

newscorp-ghfb / NewsKit

The NewsKit Design system

https://newskit.co.uk

Other

130 stars 14 forks source link

feat(TMR-1285): nonce prop to Tealium component #916

Closed tbradbury closed 1 year ago

tbradbury commented 1 year ago

https://nidigitalsolutions.jira.com/browse/TMR-1282

What

Background - why this is needed - We are using a Content-Security-Policy in Next.js that stops 3rd party scripts running unless we specify them. To enable Newskit Tealium component to work we need to be able to add a nonce attribute to the inline script.
What did you do - added optional nonce prop to Tealium script
What does the reviewers should expect

I have done:

[ ] Written unit tests against changes
[ ] Written functional tests against the component and/or NewsKit site
[ ] Updated relevant documentation

I have tested manually:

[ ] The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
[ ] The screen reader reads and flows through the elements as expected.
[ ] There are no new errors in the browser console coming from this PR.
[ ] When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
[ ] The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

pp-serviceaccount commented 1 year ago

You can preview these changes on: Documentation Site: http://ncu-newskit-docs-pr.s3-website-eu-west-1.amazonaws.com/tmr-1285-script Storybook: http://ncu-newskit-docs-pr.s3-website-eu-west-1.amazonaws.com/tmr-1285-script/storybook