search

newscred / webhook-broker

This is a fully HTTP based Pub/Sub Broker with a goal to simplify system architecture in SOA or Microservice architecture. It aims to solve the inter service communication problem.
Apache License 2.0
18 stars 25 forks source link

Fix default value for consumer type #151

Closed imran2140 closed 1 year ago

imran2140 commented 1 year ago

Default value for consumer type needs to be 1, as existing consumers are supposed to be push based.

oneshadab commented 1 year ago

Would swapping the two lines 11 and 12 be an easier solution?

That way if we initialize ConsumerType with it's zero value anywhere in the codebase, it would be push by default.

imyousuf commented 1 year ago

Would swapping the two lines 11 and 12 be an easier solution?

That way if we initialize ConsumerType with it's zero value anywhere in the codebase, it would be push by default.

I would not switch iota values, I would like to keep them as constant as possible

imyousuf commented 1 year ago

Addresses part of #53