Open zzolo opened 5 years ago
Hi, thanks for this contribution! I'll try to review it soon. Meanwhile, I'm interested in whether you've been using ai2html at the Star Tribune. It sounds like you're interested in contributing, do you have some thoughts about improving the tool, other than coding style? Cheers, mbloch
Wonderful project, thanks so much for sharing with the world.
This pull requests adds some linting and code style consistency support, which, for neurotic people like me, makes it easier to contribute. I think code styles are great, but I don't want to be preachy about it.
This adds two things:
.eslintrc.json
. It builds off the recommended linting from theeslint
module, and adds just a couple differences that I think align with the current styles.es5
plugin, as I think Illustrator uses an older version of a Javascript engine, but I can't find very definitive documentation about this.npm run lint
, which will lint the mainai2html.js
and the JS files intests/
.npm run lintFix
. This will update the files, but will also error, as there are some code that just needs to be updated to pass.Future considerations
.editorconfig
config.eslint
with prettier can be very helpful for other types of files.