search

newslynx / opportunities

A garden of NewsLynx futures
1 stars 0 forks source link

Create api_url external option in config.yaml #110

Closed mhkeller closed 9 years ago

mhkeller commented 9 years ago

During authentication, if the api url is set up as localhost:5000 than the redirect URL will be localhost, which won't work.

Here's where it comes into play for GA: https://github.com/newslynx/newslynx-core/blob/9428c92340f017d59b0698e2470b7673704bb505/newslynx/views/auth/google_analytics_auth.py#L34

Fixed on the app to take into account if they might specify a remote IP, then it's okay to use that: https://github.com/newslynx/newslynx-app/blob/master/lib/routes/authentications.js#L16-L23

mhkeller commented 9 years ago

Done in automation: https://github.com/newslynx/automation/commit/919a873ec33636af5c64dcb2c1cde143fa8049f3

And in core https://github.com/newslynx/newslynx-core/commit/a27ba3f83322c8c636f19cf91dcb9a22f1baaa00

Needs documentation