search

newslynx / opportunities

A garden of NewsLynx futures
1 stars 0 forks source link

Re-enable hash navigation #17

Closed mhkeller closed 9 years ago

mhkeller commented 9 years ago

The last piece of plumbing that's needed is fetching of articles when they are not loaded into the article drawer already.

mhkeller commented 9 years ago

For comparison view, the sort dimension and direction should be in the hash so that the UI knows what column to display

mhkeller commented 9 years ago

Progress: https://github.com/newslynx/newslynx-app/commit/b8875ec9ef45e8434f1f85da432cf2ed2b748a6a

mhkeller commented 9 years ago

Mostly done: https://github.com/newslynx/newslynx-app/commit/54b3a28a80778242c82089565cba34a003ccacac

This query param might need to be adjusted once that option gets put into the api https://github.com/newslynx/newslynx-app/blob/54b3a28a80778242c82089565cba34a003ccacac/lib/public/javascripts/routing/routing.js#L52

mhkeller commented 9 years ago

Done or comparisons: https://github.com/newslynx/newslynx-app/commit/54b3a28a80778242c82089565cba34a003ccacac Done for detail: https://github.com/newslynx/newslynx-app/commit/0b201556f33af9d4241420208ddcf22a80dc111e