newslynx / opportunities

A garden of NewsLynx futures
1 stars 0 forks source link

some sous chefs lacking event options #94

Closed mhkeller closed 9 years ago

mhkeller commented 9 years ago

I'm getting an error when opening the approval river that

obj.options.set_event_tag_ids.input_options = impactTags;
                                                    ^
TypeError: Cannot set property 'input_options' of undefined

which is caused by the set_event_tag_ids key is not present on that sous chef object

The sous chef in questions is Twitter Search To Event: https://github.com/newslynx/newslynx-sc-twitter/blob/master/newslynx_sc_twitter/twitter_search_to_event.yaml

Should it have these lines in it? https://github.com/newslynx/newslynx-sc-twitter/blob/master/newslynx_sc_twitter/twitter_list_to_event.yaml#L24-L25

its schema currently comes back as

{

    "option_order": 

[

    "name",
    "slug",
    "description",
    "api_query",
    "search_query",
    "result_type",
    "min_followers",
    "must_link",
    "schedule_by",
    "crontab",
    "minutes",
    "time_of_day",
    "event_status",
    "set_event_content_items",
    "set_event_title",
    "set_event_description",
    "set_event_tag_ids"

],
"description": "Extracts events from a Twitter API query.",
"requires_auths": null,
"id": 19,
"runs": "newslynx_sc_twitter.events.Search",
"name": "Twitter Search To Event",
"filepath": null,
"requires_settings": null,
"slug": "twitter-search-to-event",
"creates": "events",
"is_command": false,
"options": 
{

    "timeout": 

{

    "default": 240,
    "input_type": "hidden",
    "value_types": 

[

    "numeric"

],
"help": 

    {
        "placeholder": 240,
        "description": "The number of seconds after which this sous chef will time out.\n"
    }

},
"name": 
{

    "input_type": "text",
    "value_types": 

[

    "string"

],
"required": true,
"help": 

    {
        "description": "The name of the Recipe."
    }

},
"slug": 
{

    "input_type": "text",
    "value_types": 

[

    "string"

],
"required": false,
"help": 

    {
        "placeholder": "(optional)",
        "description": "The recipe slug. Lowercase and separated with '-'."
    }

},
"description": 
{

    "input_type": "paragraph",
    "value_types": 

[

    "string",
    "nulltype"

],
"required": false,
"help": 

    {
        "placeholder": "(optional)",
        "description": "A description of what this recipe does."
    }

},
"api_query": 
{

    "input_type": "text",
    "value_types": 

[

    "string"

],
"required": true,
"help": 

    {
        "link": "https://dev.twitter.com/rest/public/search",
        "placeholder": "“fracking\"",
        "description": "The query to the Twitter API to return the initial batch of tweets."
    }

},
"search_query": 
{

    "default": null,
    "input_type": "text",
    "value_types": 

[

    "searchstring",
    "nulltype"

],
"required": false,
"help": 

    {
        "placeholder": "propalpatine | /.*prplp.tn.*/",
        "description": "The query we use for additional filtration on text and urls."
    }

},
"result_type": 
{

    "value_types": 

[

    "string"

],
"help": 
{

    "link": "https://dev.twitter.com/rest/public/search",
    "placeholder": "“recent\"",
    "description": "The type of tweets to return from the Twitter API."

},
"default": "recent",
"input_type": "select",
"required": false,
"input_options": 

    [
        "recent",
        "popular",
        "both"
    ]

},
"min_followers": 
{

    "default": 0,
    "input_type": "number",
    "value_types": 

[

    "numeric",
    "nulltype"

],
"required": false,
"help": 

    {
        "placeholder": "5000",
        "description": "Filter out tweets from users with less than X followers."
    }

},
"schedule_by": 
{

    "default": null,
    "input_type": "select",
    "value_types": 

[

    "string",
    "nulltype"

],
"help": 
{

    "placeholder": "minutes",
    "description": "The method for scheduling the recipe."

},
"input_options": 

    [
        "minutes",
        "time_of_day",
        "crontab",
        "unscheduled"
    ]

},
"crontab": 
{

    "default": null,
    "input_type": "text",
    "value_types": 

[

    "crontab",
    "nulltype"

],
"help": 

    {
        "placeholder": "*/30 * * * *",
        "link": "https://en.wikipedia.org/wiki/Cron",
        "description": "A crontab string to use for scheduling this recipe."
    }

},
"minutes": 
{

    "default": null,
    "input_type": "number",
    "value_types": 

[

    "numeric",
    "nulltype"

],
"help": 

    {
        "placeholder": 60,
        "description": "The frequency with which this recipe should run (in minutes)."
    }

},
"time_of_day": 
{

    "value_types": 

[

    "string",
    "nulltype"

],
"help": 
{

    "placeholder": "4:30 PM",
    "description": "The time of day at which this recipe should run daily."

},
"default": null,
"input_type": "select",
"required": false,
"input_options": 

            [
                "12:00 AM",
                "12:30 AM",
                "1:00 AM",
                "1:30 AM",
                "2:00 AM",
                "2:30 AM",
                "3:00 AM",
                "3:30 AM",
                "4:00 AM",
                "4:30 AM",
                "5:00 AM",
                "5:30 AM",
                "6:00 AM",
                "6:30 AM",
                "7:00 AM",
                "7:30 AM",
                "8:00 AM",
                "8:30 AM",
                "9:00 AM",
                "9:30 AM",
                "10:00 AM",
                "10:30 AM",
                "11:00 AM",
                "11:30 AM",
                "12:00 PM",
                "12:30 PM",
                "1:00 PM",
                "1:30 PM",
                "2:00 PM",
                "2:30 PM",
                "3:00 PM",
                "3:30 PM",
                "4:00 PM",
                "4:30 PM",
                "5:00 PM",
                "5:30 PM",
                "6:00 PM",
                "6:30 PM",
                "7:00 PM",
                "7:30 PM",
                "8:00 PM",
                "8:30 PM",
                "9:00 PM",
                "9:30 PM",
                "10:00 PM",
                "10:30 PM",
                "11:00 PM",
                "11:30 PM"
            ]
        }
    }

},
mhkeller commented 9 years ago

Fixed via https://github.com/newslynx/newslynx-sc-twitter/commit/96715ef1694ebc17ec697b154f3ac60debd0d724 https://github.com/newslynx/newslynx-sc-twitter/commit/8cb4bf3e32efac2115c188693327304fbcdec95d