search

newsnowlabs / dockside

Develop, stage and test on-prem or in your private cloud. Dockside is a tool for provisioning lightweight access-controlled IDEs, staging environments and sandboxes - aka 'devtainers' - on local machine, on-premises raw metal or VM, or in the cloud
https://dockside.io/
Apache License 2.0
266 stars 16 forks source link

Allow '-' in devtainer names #8

Closed struanb closed 1 year ago

struanb commented 1 year ago

Currently - is not allowed in devtainer names, to allow for nested instances of Dockside i.e. developing Dockside inside Dockside.

Provide a config option that allows the use of - in devtainer names, for those who do not need to nest Dockside instances. As an alternative implementation, the nesting of Dockside instances, could be retained by allowing the use of -- instead of - to delineate nested Dockside instances.

struanb commented 1 year ago

See https://github.com/newsnowlabs/dockside/pull/15

struanb commented 1 year ago

This is implemented and tested. Release notes must inform users that the post-upgrade behaviour, for existing devtainers used for developing Dockside, is not clearly defined and access to devtainers launched 'inside' an inner Dockside development devtainer may fail. This is likely to be an unusual case and one that should not hold up release.