newsnowlabs / runcvm

RunCVM (Run Container VM) is an experimental open-source Docker container runtime, for launching standard container workloads - as well as Systemd, Docker, even OpenWrt - in VMs using 'docker run`
Apache License 2.0
211 stars 7 forks source link

alpine /dev/tty and /dev/null permissions are wrong #10

Closed struanb closed 10 months ago

struanb commented 10 months ago

Compare alpine and debian, using runcvm and runc, below:

$ docker run --rm --runtime=runcvm alpine ash -c 'ls -l /dev/tty /dev/null'
crw-rw----    1 root     root        1,   3 Nov 16 23:48 /dev/null
crw-rw----    1 root     root        5,   0 Nov 16 23:48 /dev/tty

$ docker run --rm --runtime=runc alpine ash -c 'ls -l /dev/tty /dev/null'
crw-rw-rw-    1 root     root        1,   3 Nov 16 23:48 /dev/null
crw-rw-rw-    1 root     root        5,   0 Nov 16 23:48 /dev/tty

$ docker run --rm --runtime=runcvm debian bash -c 'ls -l /dev/tty /dev/null'
crw-rw-rw- 1 root root 1, 3 Nov 16 23:49 /dev/null
crw-rw-rw- 1 root root 5, 0 Nov 16 23:49 /dev/tty

$ docker run --rm --runtime=runc debian bash -c 'ls -l /dev/tty /dev/null'
crw-rw-rw- 1 root root 1, 3 Nov 16 23:49 /dev/null
crw-rw-rw- 1 root root 5, 0 Nov 16 23:49 /dev/tty
struanb commented 10 months ago

Fixed in commit https://github.com/newsnowlabs/runcvm/commit/b27dea7afc311544660167b0db5a9d2137289a36

$ docker run --rm --runtime=runcvm alpine ash -c 'ls -l /dev/tty /dev/null'
crw-rw-rw-    1 root     root        1,   3 Nov 21 22:28 /dev/null
crw-rw-rw-    1 root     tty         5,   0 Nov 21 22:28 /dev/tty