search

newspeaklanguage / newspeak

Newspeak is a live object-capability language in the Smalltalk tradition
https://newspeaklanguage.org/
Other
132 stars 11 forks source link

Senders/implementers/references menus should dispaly only selectors, not literal strings #100

Closed gbracha closed 7 months ago

gbracha commented 2 years ago

Any literal string in a method is currently displayed (truncated to length 64). Ideally, non-selectors should not be listed. One might debate this; it can be useful to search for an occurrence of a literal string (but that doesn't actually work right now either). In any event, this is an exceedingly minor issue and not a priority at all.

gbracha commented 8 months ago

Current fix is to filter out strings with a space. This is not exactly correct, but gets rid of most egregious examples. There's also a problem that certain common selectors don't show up, because we don't store them in the literal table. We could store them in the table anyway (wasting space). We could ignore the literal table and simply parse the source and look for message sends, to get a fully correct result. We could restrict ourselves to the literal table, but parse the entries to filyer out non-selectors regardless of spaces.

gbracha commented 7 months ago

Fixed by Hayley as of Jan 31st, 2024