newspeaklanguage / newspeak

Newspeak is a live object-capability language in the Smalltalk tradition
https://newspeaklanguage.org/
Other
132 stars 11 forks source link

Adding members in debugger in response to DNU may fail #104

Closed gbracha closed 2 years ago

gbracha commented 2 years ago

The debugger has a feature that allows you to immediately add a method/class/slot in response to a DNU. The problem is that it fails in cases where the receiver class has exemplar data. The code operates browsing the receiver class and manipulating the presenter that is active at that point. The code predates the introduction of exemplars. When it was written, browsing a class meant that the current presenter would be a class presenter. Now, however, it may be an object presenter (in cases where the class has exemplar metadata). Object presenters do not respond to the same messages as class presenters, and so things go bad. We can extend object presenters with the missing methods, or change the code to check what the current presenter is and act accordingly. I think the former is cleaner.

gbracha commented 2 years ago

Looks like that's fixed