search

newspeaklanguage / newspeak

Newspeak is a live object-capability language in the Smalltalk tradition
https://newspeaklanguage.org/
Other
132 stars 11 forks source link

Test results twice in the history #81

Closed gbracha closed 1 year ago

gbracha commented 3 years ago

The progress bar leaves an extra entry?

gbracha commented 1 year ago

This had to do with a bug in HyperLinkFragment. When updating its visual (DOM representation), it put its revised onClick handler on a different element than when the visual was first created. As a result, links of updated presenters might have two active handlers. At a minimum, this was wasteful. If the handler had side-effects, this could induce bugs like this one: the tests were run twice, manifesting as duplicate results in the history. Updates to link actions might also misbehave.