newspeaklanguage / newspeak

Newspeak is a live object-capability language in the Smalltalk tradition
https://newspeaklanguage.org/
Other
132 stars 11 forks source link

System crash in workspace when message widget is closed after syntax error #92

Closed mzimmerm closed 3 years ago

mzimmerm commented 3 years ago

Steps to duplicate:

From a follow up by Gilad on the google group, this is a system crash:

What happens is that, when we have a syntax error, clearing the result list gets to deal with a parse error instead of a thread, which is what it expects. And, because we have a longstanding problem that crashes within the IDE don't go to the debugger, the result is a complete crash :-(. The system is dead; the editor is a CodeMirror editor, and it's javascript code keeps responding to events, so you can still type into it - so it may not be obvious that the system actually crashed.

mzimmerm commented 3 years ago

Gilad fixed this even before I reported this :)

For the record: I bring the fix in like this: