fix: Snapshot makes shot even when its failed on specific functionality

newsuk / AyeSpy

A performant visual regression testing tool

BSD 3-Clause "New" or "Revised" License

206 stars 13 forks source link

fix: Snapshot makes shot even when its failed on specific functionality #177

Closed lukasr22 closed 5 years ago

lukasr22 commented 5 years ago

AyeSpy have special functionality : removeElements, hideElements, waitForElement, onReadyScript, ... and when its selector cannot be found snapshot is not available. This fix pretend this step and even selector is not defined correctly or missing on page which still goes to make shot of page and compare with Baseline.

L0wry commented 5 years ago

It would also be good to have an e2e test making sure that both the application exits when connection to grid fails + a wait fails but we still snap