search

newtmitch / docker-sonar-scanner

Quick sonar scanner docker image
MIT License
129 stars 88 forks source link

add node.js to alpine image #15

Closed mobidev111 closed 5 years ago

mobidev111 commented 5 years ago

could node.js as well be added to the alpine-based image? currently it's only included in the full version.

To support JS/TS scanning.

follow up to #9

newtmitch commented 5 years ago

Thanks for the spot on this, @mobidev111 - I've added it to the apk add command and it looks like it "took" okay, but I don't have time to test this for a little while. If I push this up to a branch would you be able to pull that down and make sure it solves the problem for you?

mobidev111 commented 5 years ago

Yes, I can try this out.

pawelmarkowski commented 5 years ago

could you publish the fix on the dockerhub? @newtmitch

newtmitch commented 5 years ago

I can do that. Was waiting to hear from @mobidev111 to see if it worked out right first, but might go ahead and push anyway if I don't hear back. 😄

newtmitch commented 5 years ago

@pawelmarkowski pushed. let me know if any issues.

pawelmarkowski commented 5 years ago

@newtmitch works great! Thanks