Closed lmb closed 5 years ago
Merging #96 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #96 +/- ##
=======================================
Coverage 59.03% 59.03%
=======================================
Files 24 24
Lines 1877 1877
=======================================
Hits 1108 1108
Misses 605 605
Partials 164 164
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 371e351...064cba4. Read the comment docs.
There is a lot of code duplication between the examples, which makes it hard to see the different approaches. The file based example is also missing instructions how to obtain "sockex1".
Keep the example loading from a byte array, since it covers more parts of the API.