Update Node Version in GitHub actions to use LTS - Githubissues

newwwie / newwwie.com

The source for newwwie.com website. The front door to the Newwwie Slack and tech + digital creative community.

https://newwwie.com/

MIT License

15 stars 22 forks source link

Update Node Version in GitHub actions to use LTS #105

Closed younglondon closed 4 months ago

younglondon commented 4 months ago

From what I can tell, this change was all that was needed? The action ran and passed in a different test repo I had.

-- Corey

neozenith commented 4 months ago

Thanks for working on this!

We do have some resources that could be helpful with learning more about creating pull requests and inparticular pull requests across forks:

Contributing guidelines around pull requests
- Github: Creating a Pull Request across forks
The tl;dr:
- Create a fork ✅
- Create a new branch 🤷‍♂️
- Open the pull request from your fork and branch back against newwwie.com:main
- Allow maintainers to make edits
To address #102 I am pretty sure it literally needs only the .github/workflows/build.yml change that you made.

In the Pull Request description also adding Fixes #102 will also close the ticket once merged.

I see you've also started work on the Playright stuff. That should be a separate pullrequest to keep each change isolated and as small as possible. It makes it easier to review.