Melpa package of magithub broken

nex3 / magithub

Magit + GitHub

42 stars 13 forks source link

Melpa package of magithub broken #11

Open michael-heerdegen opened 11 years ago

michael-heerdegen commented 11 years ago

Hello,

I have magit and magithub installed with M-x package-list-packages. When I try to load magit (yes, magit, not magithub), I get this error:

(void-variable magit-log-edit-confirm-cancellation)

This is what's happening:

loading magit triggers loading magithub because of

;;;###autoload (eval-after-load 'magit '(unless (featurep 'magithub) (require 'magithub)))

in magithub, there is this form:

(defcustom magithub-message-confirm-cancellation magit-log-edit-confirm-cancellation "If non-nil, confirm when cancelling the editing of a `magithub-message-mode' buffer." :group 'magithub :type 'boolean)

evaluating it raises the error because magit-log-edit-confirm-cancellation is not defined.

Maybe the variable has been removed? Dunno.

Michael.

pashinin commented 11 years ago

Confirm

pokehanai commented 11 years ago

aspiers commented 11 years ago

jasonm23 commented 11 years ago

Question, why is this closed when the MELPA install is still broken?

flexibeast commented 11 years ago

@jasonm23:

As far as I can tell, looking at the issue status indicator at the top of this page, this issue isn't closed. If I'm understanding things correctly, the 'Closed' indicator earlier in this thread is a reference to the issue being closed on the /magit/ repo, as the issue is not with magit itself, but with /magithub/, a distinct project.

jasonm23 commented 11 years ago

@flexibeast thanks for clearing that up. It seems that the melpa package is still a release from July. (?)

flexibeast commented 11 years ago

@jasonm23:

Yes, that's the latest release I'm seeing also .... Basically I've uninstalled magithub until this issue is fixed, so that I can at least continue using magit.

Blaisorblade commented 11 years ago

I had the same problem. It seems that saving magithub-message-confirm-cancellation from M-x customize-group RET magithub RET also works the problem around (I guess because once the variable is set, reading the default isn't needed any more).

dcunited001 commented 10 years ago

alexvorobiev commented 10 years ago

Adding (defvar magit-log-edit-confirm-cancellation nil) prior to loading magit is another workaround.

Blaisorblade commented 10 years ago

Apparently magithub is unsupported and does not work anyway, see https://github.com/milkypostman/melpa/issues/1126.