Closed pombredanne closed 2 years ago
I am new to the open-source environment, and I would like to contribute to this issue if it's still unsolved, and it's my request to help me with the references required for this.
Welcome to the open source community @RahulSingh212 and thanks for your interest!
As you can see from the search link above, the issue is still unsolved.
First click on the search link above and browse through all the results.
You will note that some of the results are listing the #aboutcode channel on freenode and those are usually in README or CONTRIBUTING files. Other results are listing other channels and those are usually in example, test or third-party code related files. Please ignore the example/test and third-party code results.
Then make a list of the GitHub repositories that contain non-ignored references to freenode.
Then take a look at this site for info about Libera Chat:
Then for each of the GitHub repositories on your list, make a fork of the repository. Then edit the files mentioning freenode and replace that with the equivalent Libera Chat info. Then commit the changes (ensure you link to this issue from your commit messages) and push the commits to your forks. Then submit pull requests for each of the commits. The GitHub documentation about pull requests is here:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests
If you need any assistance, we can discuss it here or on the #aboutcode channel on the Libera Chat IRC network.
-- bye, pabs
Hi, I am looking forward to work on this issue. Is it still open and unresolved?
@DebDx thanks for your interest! As you can see from the search link above, the issue is still unsolved.
Hi @pombredanne, I am working on this.
@PurnaChandraMansingh all merged now.. I think this is done! Thank you ++ for carrying this through!
Thank you so much @pombredanne for this opportunity : ) Finally, I had completed my first step 😇
could you please verify once, the search result which are showing now needs any modification on not https://github.com/search?p=2&q=org%3AnexB+freenode&type=Code
and do have any new tasks for me? I am happy to perform😊 I will be happier if you can give some feedback/improvement for my future contribution.
@PurnaChandraMansingh @pombredanne there are still more references to freenode, so I don't think this one is fixed yet.
I think that at minimum these ones need to be fixed:
https://github.com/nexB/tracecode-toolkit/blob/master/.travis.yml#L54 https://github.com/nexB/scancode-toolkit/blob/develop/etc/scripts/irc-notify.py#L142 https://github.com/nexB/scancode-toolkit-contrib/blob/master/.travis.yml#L17 https://github.com/nexB/scancode-toolkit-contrib/blob/master/etc/scripts/irc-notify.py#L132
Maybe this one should be fixed too:
https://github.com/nexB/aboutcode/blob/master/docs/source/gsoc/gsoc_2017.rst#L41
I don't have enough disk space to check out all the nexB repositories to grep them, but the above are the ones GitHub search still finds.
-- bye, pabs
Thank you, @pabs3. I replace the Freenode in https://github.com/nexB/aboutcode/blob/master/docs/source/gsoc/gsoc_2017.rst#L41
Since other files are not doc files, I am waiting for @pombredanne input to modify them. Do you have any suggestions/guidance on how to modify them?
Thanks
Hi @pombredanne, kindly let me know if I can modify the above files or not
of course :)
Hi @pombredanne, I have a doubt here, I just changed
notifications:
irc:
channels:
- "chat.freenode.net#aboutcode"
to
notifications:
irc:
channels:
- "web.libera.chat#aboutcode"
Is this correct? Should I also add the Gitter URL?
https://github.com/nexB/scancode-toolkit/blob/develop/etc/scripts/irc-notify.py#L142 this is no longer available
https://github.com/nexB/scancode-toolkit-contrib/blob/master/etc/scripts/irc-notify.py#L132
irc_sock.connect((socket.gethostbyname('chat.freenode.net'), 6697))
is this port number(6697) remain same ? like
irc_sock.connect((socket.gethostbyname('web.libera.chat'), 6697))
web.libera.chat is for the web client, the files you are changing aren't connecting to the web client, but to the IRC server, so you should use irc.libera.chat instead of web.libera.chat.
Since the irc-notify.py script got removed from scancode-toolkit, probably it should just get removed from scancode-toolkit-contrib too.
https://github.com/nexB/scancode-toolkit/commits/develop/etc/scripts/irc-notify.py
-- bye, pabs
Thanks, @pabs3 @pombredanne, I also deleted the below file and used irc.libera.chat https://github.com/nexB/scancode-toolkit-contrib/blob/master/etc/scripts/irc-notify.py#L132 but now I am getting the below error, could you please guide how to proceed
yield 'ERROR: ' + error
E TypeError: cannot concatenate 'str' and 'type' objects
Probably you are using Python 3 but the script requires Python 2 or the other way around.
-- bye, pabs
Actually, I made a PR https://github.com/nexB/scancode-toolkit-contrib/pull/6 after the necessary changes but it's falling some test
Hello, @pombredanne. I see two PRs for this issue are still open.
Are they relevant?
@pabs3 reported to me that we still have some outdated freenode references https://github.com/search?q=org%3AnexB+freenode&type=code
We should use only Gitter and liberachat