search

nexB / purldb

Tools to create and expose a database of purls (Package URLs). This project is sponsored by NLnet project https://nlnet.nl/project/vulnerabilitydatabase/ and nexB for https://www.aboutcode.org/ Chat is at https://gitter.im/aboutcode-org/discuss
https://purldb.readthedocs.io/
29 stars 21 forks source link

Update purldb-toolkit and related README files #249 #450

Closed johnmhoran closed 1 month ago

johnmhoran commented 1 month ago

Reference: https://github.com/nexB/purldb/issues/249 Reference: https://github.com/nexB/purldb/issues/446

johnmhoran commented 1 month ago

@AyanSinhaMahapatra I've just committed and pushed my updates responding to your comments (thank you for those). One open item concerns your comment re the truncated text in purlcli --help -- I noted that the full text might be long enough to wrap and some might find that unsightly. Please let me know at your convenience how you'd like me to handle that.

AyanSinhaMahapatra commented 1 month ago

@johnmhoran here's some directions on the truncated help text: https://stackoverflow.com/questions/75036688/display-full-help-text-in-python-click, but let's not do too much here. We should rather keep this short and concise so it fits the CLI display (first line of a docstring short text for this, next paragraph for detailed docstring). LGTM otherwise!

AyanSinhaMahapatra commented 1 month ago

@johnmhoran let's handle this seperately in #455, merging the PR otherwise, thanks!

johnmhoran commented 1 month ago

Thank you @AyanSinhaMahapatra 👍