search

nexB / python-inspector

Inspect Python code and PyPI package manifests. Resolve Python dependencies.
20 stars 17 forks source link

relative links_fix #134

Closed gmathiou4 closed 11 months ago

gmathiou4 commented 1 year ago

This a fix for issue https://github.com/nexB/python-inspector/issues/129

Signed-off-by: Georgios Mathioudakis georgios.mathioudakis@here.com

TG1999 commented 1 year ago

@gmathiou4 thanks for the PR, it would be nice if you could add some tests to verify your changes.

gmathiou4 commented 1 year ago

@TG1999

Still i have 2 failing tests unrelated to my changes

FAILED tests/test_codestyle.py::BaseTests::test_codestyle - Exception: ('Code style check failed!', b"-> Run pycodestyle (PEP8) validation\n./inspec/lib/python3.11/site-packages/pip_requirements_parser.py:103:77: W291 trailing whitespac...
FAILED tests/test_resolution.py::test_without_supported_wheels - AttributeError: 'IfExp' object has no attribute 'elts'

How would you suggest to proceed with those?

TG1999 commented 1 year ago

@gmathiou4 for FAILED tests/test_codestyle.py::BaseTests::test_codestyle - Exception: ('Code style check failed!', b"-> Run pycodestyle (PEP8) validation\n./inspec/lib/python3.11/site-packages/pip_requirements_parser.py:103:77: W291 trailing whitespac

Please run make valid command

TG1999 commented 1 year ago

@gmathiou4 I ran the tests on your branch locally, I was not able to re-create this error FAILED tests/test_resolution.py::test_without_supported_wheels - AttributeError: 'IfExp' object has no attribute 'elts'

gmathiou4 commented 1 year ago

@gmathiou4 for FAILED tests/test_codestyle.py::BaseTests::test_codestyle - Exception: ('Code style check failed!', b"-> Run pycodestyle (PEP8) validation\n./inspec/lib/python3.11/site-packages/pip_requirements_parser.py:103:77: W291 trailing whitespac

Please run make valid command

After running make valid command again i still have the same error

gmathiou4 commented 1 year ago

@TG1999 The tests are fixed now, please proceed with the review

TG1999 commented 1 year ago

@gmathiou4 thanks! just a minor nitpick for your consideration https://github.com/nexB/python-inspector/pull/134#discussion_r1250523215

gmathiou4 commented 1 year ago

@TG1999 Docetest added, is there anything else missing?

gmathiou4 commented 1 year ago

@TG1999, is anything else needed from my side? I see there is a UndefinedError("'style' is undefined") But i didn't have any relevant error locally

TG1999 commented 1 year ago

@gmathiou4 LGTM! thanks! @pombredanne please can you have a second look at this once?

gmathiou4 commented 11 months ago

Hello, Could you please review the changes and let me know if you have another suggestion before the merge?

TG1999 commented 11 months ago

@gmathiou4 please squash your commits

pombredanne commented 11 months ago

@TG1999 the tests are failing... may be a skeleton issue? I see also https://github.com/nexB/python-inspector/pull/119 ... so I guess I'll approve and we can do it later.

TG1999 commented 11 months ago

@TG1999 the tests are failing... may be a skeleton issue? I see also #119 ... so I guess I'll approve and we can do it later.

@pombredanne CI is failing due to this https://github.com/sphinx-doc/sphinx/pull/11381

TG1999 commented 11 months ago

Thanks @gmathiou4 merging :heart:

gmathiou4 commented 11 months ago

@TG1999, Thanks for merging! Could you please help me clarify, if "main"= "tag 0.9.7". If not, does that means that always the latest version is the main branch?

gmathiou4 commented 11 months ago

@TG1999 & @pombredanne Could you please release a new tag with the latest changes?

TG1999 commented 11 months ago

@gmathiou4 released v0.9.8 here https://pypi.org/project/python-inspector/0.9.8/