search

nexdome / ASCOM

NexDome ASCOM Driver
https://www.nexdome.com
MIT License
6 stars 7 forks source link

Driver is not correctly parsing the dead-zone from the rotator status message #20

Closed NameOfTheDragon closed 3 years ago

NameOfTheDragon commented 4 years ago

Consider the following log fragment:

15:48:51.5166|DEBUG|ObservableDiagnosticExtensions|Serial Receive[1]: OnNext(:)
15:48:51.5166|DEBUG|ObservableDiagnosticExtensions|Serial Receive[1]: OnNext(S)
15:48:51.5166|DEBUG|ObservableDiagnosticExtensions|Serial Receive[1]: OnNext(E)
15:48:51.5166|DEBUG|ObservableDiagnosticExtensions|Serial Receive[1]: OnNext(R)
15:48:51.5166|DEBUG|ObservableDiagnosticExtensions|Serial Receive[1]: OnNext(,)
15:48:51.5166|DEBUG|ObservableDiagnosticExtensions|Serial Receive[1]: OnNext(0)
15:48:51.5166|DEBUG|ObservableDiagnosticExtensions|Serial Receive[1]: OnNext(,)
15:48:51.5166|DEBUG|ObservableDiagnosticExtensions|Serial Receive[1]: OnNext(1)
15:48:51.5166|DEBUG|ObservableDiagnosticExtensions|Serial Receive[1]: OnNext(,)
15:48:51.5166|DEBUG|ObservableDiagnosticExtensions|Serial Receive[1]: OnNext(5)
15:48:51.5166|DEBUG|ObservableDiagnosticExtensions|Serial Receive[1]: OnNext(5)
15:48:51.5166|DEBUG|ObservableDiagnosticExtensions|Serial Receive[1]: OnNext(0)
15:48:51.5166|DEBUG|ObservableDiagnosticExtensions|Serial Receive[1]: OnNext(8)
15:48:51.5166|DEBUG|ObservableDiagnosticExtensions|Serial Receive[1]: OnNext(0)
15:48:51.5166|DEBUG|ObservableDiagnosticExtensions|Serial Receive[1]: OnNext(,)
15:48:51.5166|DEBUG|ObservableDiagnosticExtensions|Serial Receive[1]: OnNext(0)
15:48:51.5166|DEBUG|ObservableDiagnosticExtensions|Serial Receive[1]: OnNext(,)
15:48:51.5166|DEBUG|ObservableDiagnosticExtensions|Serial Receive[1]: OnNext(5)
15:48:51.5166|DEBUG|ObservableDiagnosticExtensions|Serial Receive[1]: OnNext(0)
15:48:51.5166|DEBUG|ObservableDiagnosticExtensions|Serial Receive[1]: OnNext(#)
15:48:51.5166|DEBUG|ObservableDiagnosticExtensions|IRotatorStatus[1]: OnNext(AtHome: True, Azimuth: 0, DeadZone: 0, DomeCircumference: 55080, HomePosition: 0)
15:48:51.5166|INFO |ControllerStateMachine|Rotator status AtHome: True, Azimuth: 0, DeadZone: 0, DomeCircumference: 55080, HomePosition: 0
15:48:51.5166|DEBUG|RotatorStateBase|Status received: AtHome: True, Azimuth: 0, DeadZone: 0, DomeCircumference: 55080, HomePosition: 0
15:48:51.5326|DEBUG|RotatorStateBase|Entering "ReadyState"
15:48:51.5326|DEBUG|ObservableDiagnosticExtensions|Serial Receive[1]: OnNext(

It can be seen that '50' is being reported as the dead-zone in the status response, but the driver is reporting '0' as the dead zone.

NameOfTheDragon commented 3 years ago

Done - fixed in PR #36 Release 4.0.0