search

nexdome / ASCOM

NexDome ASCOM Driver
https://www.nexdome.com
MIT License
6 stars 7 forks source link

Add SyncAzimuth support #32

Closed ghilios closed 3 years ago

ghilios commented 3 years ago

I wasn't able to test this against develop because there are dependencies not yet on NuGet. I did test this on 3.1.0 though.

NameOfTheDragon commented 3 years ago

That was quick work, @ghilios. If you did want to test against develop, you could add my pre-release feed to your NuGet sources: image

ghilios commented 3 years ago

Thanks @NameOfTheDragon , I've been around the block :) This was laid out in a pretty straightforward manner, which made it easy to work my way around.

I'll make this change. I added your nuget repository, and it seems like the closest version available there is "1.3.0-alpha0010". Am I looking in the wrong place? I am using https://www.myget.org/F/tigra-astronomy/api/v3. I don't see that version in https://www.myget.org/F/tigra-astronomy/api/v3/flatcontainer/ta.ascom.reactivecommunications/index.json

ghilios commented 3 years ago

I updated the code, but haven't been able to test it. If you can help me sort out the nuget package issue, I'll make sure it works first!

ghilios commented 3 years ago

@NameOfTheDragon , just checking in. Were you able to look into the missing package? I'd like to validate this works on head

NameOfTheDragon commented 3 years ago

@NameOfTheDragon , just checking in. Were you able to look into the missing package? I'd like to validate this works on head

@ghilios Apologies, it looks like as its an alpha release its on my integration builds feed, which is different again. This will be released to NuGet by the time I do the next driver release, but for now you could use this feed instead: http://teamcity.tigra-astronomy.com:8111/guestAuth/app/nuget/feed/TigraOss/TigraOSS/v3/index.json

Sorry to make you jump through an extra hoop. I should be working on this some time in the coming week so if you prefer to wait then feel free.