search

nexml / bio-nexml

BioRuby plugin to read and write NeXML data
http://nexml.github.com/bio-nexml/
MIT License
8 stars 4 forks source link

bio dependencies #9

Closed mjy closed 6 years ago

mjy commented 6 years ago

@pjotrp besides the namespacing, does this library require code outside of /lib? My superficial assessment is that it doesn't.

It's been a while since I've dived into /bio, so this is an ignorant question, but could you briefly highlight reasons for not extracting this library to a stand-alone gem without the overhead of the rest of bio?

pjotrp commented 6 years ago

Nexml is a phylogenetic format that can be used outside bio. I don't think there are any real dependencies on bio. Feel free to remove.

yeban commented 6 years ago

Sorry, there is. bio-nexml's trees are derived from bio's.

Any problem with dependencies is with the xml parser (libxml-ruby).

pjotrp commented 6 years ago

So, if you want to move out, create another tree object. Should not be too hard. Bio is pure Ruby, so hardly a real issue.

pjotrp commented 6 years ago

I think this issue can be closed. It is not really a bug.

mjy commented 6 years ago

I agree, but since when are issues always bugs?