nexmo-community / build-a-thing-video

A project being built live every two weeks at twitch.tv/vonagedevs
MIT License
3 stars 9 forks source link

Refactor `created` function from room.html #31

Closed gahag closed 3 years ago

gahag commented 3 years ago

If bug fixes or new features

Fixes #25

netlify[bot] commented 3 years ago

Deploy request for build-a-thing-video pending review.

Review with commit 59aeff0369890522bc79be17f6b0809d0f5ddd15

https://app.netlify.com/sites/build-a-thing-video/deploys

gahag commented 3 years ago

@phazonoverload please tell me if any further improvements can be made. Thank you.

phazonoverload commented 3 years ago

Awesome, thank you. I think the event handlers should be in their own method too - so one for streamCreated, one for streamDestroyed and one for the signal

gahag commented 3 years ago

Sure, I'll update it right away.

gahag commented 3 years ago

@phazonoverload Thank you for the suggestion. It is implemented now.

phazonoverload commented 3 years ago

Solid changes, thank you.