Closed gahag closed 3 years ago
Deploy request for build-a-thing-video pending review.
Review with commit 59aeff0369890522bc79be17f6b0809d0f5ddd15
@phazonoverload please tell me if any further improvements can be made. Thank you.
Awesome, thank you. I think the event handlers should be in their own method too - so one for streamCreated, one for streamDestroyed and one for the signal
Sure, I'll update it right away.
@phazonoverload Thank you for the suggestion. It is implemented now.
Solid changes, thank you.
Please check if the PR fulfills these requirements
[x] You've followed the contributing guidelines
[x] You've adhered to the code of conduct
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
[ ] Bug Fix
[ ] New Feature
[ ] Documentation Update
[x] Other: refactor
If bug fixes or new features
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
Fixes #25