nexmo-se / video-api-effects

MIT License
4 stars 8 forks source link

removed unused dependencies to tensorflow #11

Closed davideberlein closed 2 years ago

davideberlein commented 2 years ago

When I saw the produced UMD files I realized that they were extremely large (900kb). After inspecting this it turned out, that this was due to the tensorflow imports which however aren't used at all.

I would suggest removing these dependencies (shrinking the lib to 20kb) for now and relying on the tflite wasm implementation.

In a second step, support for non wasm can be added again if needed. WDYT?

davideberlein commented 2 years ago

@enricop89 did you see this PR?

enricop89 commented 2 years ago

@davideberlein just saw it now. I'll review soon and release

enricop89 commented 2 years ago

LGTM ⬆️ Merged