Refactor library, adding all features needed for productive usage

nexmo-se / video-api-effects

MIT License

4 stars 8 forks source link

Closed davideberlein closed 2 years ago

davideberlein commented 2 years ago

Extract BackroundEffectProcessor class from BackgroundEffect:
- BackroundEffectProcessor is responsible for the lifecycle, allowing pausing, switching source, disabling the effect while always keeping one steady output stream.
- BackgroundEffect and its implementation is responsible for the actual background replacement effect
Update documentation
Update sample app

See the updated documentation for details

New demo page:

enricop89 commented 2 years ago

Thanks for the PR @davideberlein , I left a comment

davideberlein commented 2 years ago

@enricop89 have you had any time to look at the changes yet?

enricop89 commented 2 years ago

Yes, the code looks great. Give me a bit of time to test it locally. Thanks again for your great work

enricop89 commented 2 years ago

LGTM