search

nexogen-international / Nexogen.Libraries.Metrics

Library for collecting application metrics in .NET and exporting them to Prometheus
MIT License
61 stars 9 forks source link

Routing update #21

Closed gideonkorir closed 6 years ago

gideonkorir commented 6 years ago

This PR fixes this issue. I've expanded the solution I posted in the comments and now works with nested routing. Also added tests to validate that routing is captured as expected.

kodfodrasz commented 6 years ago

Hi @gideonkorir,

Thank you very much for the PR! I did not have time yet to review it, but I will check your proposal next week!

Best Regards!

gideonkorir commented 6 years ago

Do you mind me sorting this while I'm at it? Currently, i'm working on a MassTransit background job that consumes messages from an input queue and the code is odd to say the least

kodfodrasz commented 6 years ago

@gideonkorir regarding Issue #22 could you please submit in a separate PR? We prefer smaller PRs with as narrow scope as possible.

gideonkorir commented 6 years ago

@kodfodrasz fixed merge conflict after another PR was merged