search

nexogen-international / Nexogen.Libraries.Metrics

Library for collecting application metrics in .NET and exporting them to Prometheus
MIT License
61 stars 9 forks source link

Add instance label and default labels to PGW endpoint #9

Closed endofcake closed 6 years ago

endofcake commented 6 years ago

PushGateway endpoint allows us to add instance and an arbitrary number of labels by using an endpoint in the form of:

/metrics/job/<JOBNAME>{/<LABEL_NAME>/<LABEL_VALUE>}

This addresses https://github.com/nexogen-international/Nexogen.Libraries.Metrics/issues/6 and https://github.com/nexogen-international/Nexogen.Libraries.Metrics/issues/7

How it looks like in Prometheus after scraping PushGateway:

prometheus

farkasmark commented 6 years ago

Hi @endofcake! I have looked at your PR and I believe it solves the issues you have raised. @ahoka will take a look tomorrow and we'll merge your pull request if he won't have further comments/questions.

endofcake commented 6 years ago

Thanks for merging this @farkasmark . What is the process for releasing an updated nuget?

farkasmark commented 6 years ago

@endofcake We have released a new v2.2.0 version of the Nuget. Currently it is being built by Travis CI.

endofcake commented 6 years ago

Excellent, thanks!