Closed gondiaz closed 3 years ago
As we talked offline @halmamol, I have implemented the internal tube of the calibration port filled with air. The tube only spans up to the vessel internal wall, similarly as in NextNew. The vertex generation is done throughout the whole tube. This is simplified version of the source calibration generation and can be modified in the future once we implement the ICS holes and final confirmation on the source emission points.
I have checked the PR and as it is mentioned, it gives an updated version of the NEXT100 Vessel using up to date design drawings. It includes the vessel body, removes parts that are not included in the final design (as the 'vacuum manifold') and implements the calibration ports and their vertex generators.
Prior any final approval, needs to be mentioned/discussed:
With the exception of these points, what is included in this PR works fine and looks ready for approval.
Please, review all the solid unions, to add some overlap between volumes, in case some of them don't have it.
The vertex generation is done throughout the whole tube. This is simplified version of the source calibration generation and can be modified in the future once we implement the ICS holes and final confirmation on the source emission points.
So, if I understand correctly, the PORT_1a
etc. vertices are meant to simulate calibration sources, not background. I have two comments here: 1. do we need to generate also background from the port volumes (not the internal tube, but the ports of the vessel)? Or do we assume that the volume is negligible? I think that right now the VESSEL
vertex generator does not include the ports (correct me if I'm wrong), 2. it's quite unlikely that a calibration source is distributed along the internal tube, right? It is usually a capsule, placed at some distance along the tube (usually at the bottom of it). Probably we will want to simulate calibration sources before having a true source to model, so I suggest to model the vertex as the sources we use in NEW.
Yes, PORT_1a
, etc.. are the ports to simulate the calibration sources. They are composed by a nozzle and by an inner tube (as you might see in the last slide).
From your comment 2), I have modified the ports such that:
source_height_
. This size is preliminary set to 5 mm, but we should get this value in the future, as well as the exact source position.port_tube_height_
to set the inner tube height, where the source lives. Once the ICS is implemented with the holes at the right place, we can enlarge the inner tube by just changing this variable. This variable is set now to port_base_height_
in order to avoid overlap with the currently implemented ICS.From your comment 1), you are right that the nozzles are not included in the VESSEL vertex generator. The steel volume of the nozzles is negligible thus I think that implementing it would make the code unnecessary complex. We are also neglecting steel from the gas nozzles.
Also, I have added an offset to overlap the union of the steel port nozzle base and cap. That is the only union that was not overlaped.
I have reviewed the last commits, and everything seems fine. Just for the record, I'm going to summarize the few points that we need to take into account in future PRs:
source_height_
is created to define the vertex creation, with a preliminary value of 5mm, that need to be updated in the future.
This PR reviews the NEXT100 steel vessel which covers the inner elements. The geometry was almost rewritten, since based on the drawings, the dimensions and some elements did not correspond with the previous implementation. Overall the changes are the following:
Issues and notes:
Below, I append a summary of the vessel meassurements and parts, as well as the 2D drawing from which I took the information. next100vessel.pdf 00-02.pdf 000-90.pdf 000-91.pdf 000-92.pdf