search

next-exp / nexus

Geant4 simulation framework of the NEXT Collaboration
5 stars 55 forks source link

Ionization energy & Fano Factor of Xenon gas #12

Open jmunozv opened 4 years ago

jmunozv commented 4 years ago

Currently these values are hard-coded into IonizationClustering.cc

These Xenon Gas properties should be set in OpticalMaterialProperties.cc, and IonizationClustering.cc get them from there. There is commented code ready to do this.

At the same time, we should check that the values set are the most updated ones.

paolafer commented 6 days ago

The problem I see is that these are not optical material properties, per se. However, we have no other places where we define material properties. If these are the only non-optical material properties throughout nexus, maybe we can leave them where they are now.

gonzaponte commented 6 days ago

Actually, the name OpticalMaterialProperties is misleading. In G4 these are just generic material properties tables. It just happens that most of them are optical stuff. For example, the scintillation parameters are also stored in these tables, which one may say has to do with optical properties, but not really (it doesn't say anything about how the photons interact with the material). I believe the material properties tables are just a very generic way for the user to hold any data related to the material and use it elsewhere in the physics code.

paolafer commented 6 days ago

Ok, so are you proposing to change the name to MaterialProperties, generically? I think it makes sense.

gonzaponte commented 6 days ago

It would be technically more correct and probably good enough to not confuse users.