search

next-exp / nexus

Geant4 simulation framework of the NEXT Collaboration
5 stars 55 forks source link

Allow no teflon in NextFlex geometry #126

Closed DiegoLopezGutierrez closed 2 years ago

DiegoLopezGutierrez commented 3 years ago

This PR allows the possibility of no teflon in the NextFlex geometry and adds the corresponding verbosity for future reference. It changes the building of the teflon by turning the teflon solid into a subtraction solid of the teflon with no holes and the teflon with holes. It also changes the SiPM build accordingly. The modifications are based on those of jmunozv/nexus/FlexTPnoTeflon branch.

paolafer commented 2 years ago

The automatic build is failing at the level of Nix. If @jmunozv has run the tests as part of the review, I would merge anyway. Please, confirm.

jacg commented 2 years ago

The automatic build is failing [...] I would merge anyway.

If automatic tests fail, they need to be fixed rather than ignored. Otherwise, it's just like not having automatic tests.

In this case the solution is (almost certainly) to upgrade to the most recent versions of the relevant GHA actions:

paolafer commented 2 years ago

A fix has been merged to the master. Please, @DiegoLopezGutierrez, rebase this branch on the master and, once the tests pass, I'll merge it.