search

next-exp / nexus

Geant4 simulation framework of the NEXT Collaboration
5 stars 55 forks source link

Move function definitions where the smart pointer is complete #164

Closed paolafer closed 2 years ago

paolafer commented 2 years ago

I've noticed that a compilation error is prompted when nexus is used as a third party library by an external software. The reason of the error is that we use a forward declaration of the smart pointer in DetectorConstruction.h and we use the move assignment operator in an inline function in the same header file. However, when the move assignment operator is used, the smart pointer needs to be complete, which is not the case in DetectorConstruction.h, because of forward declaration. Therefore, this PR moves the definitions of the functions to the .cc file.

paolafer commented 2 years ago

This PR is becoming urgent, can the designated reviewers (@jmalbos and @gondiaz) deal with it before the end of the week? Otherwise I would ask @gonzaponte to step in if he's available.

gondiaz commented 2 years ago

I wont be able to make it soon...

On Wed, Jun 15, 2022, 08:27 Paola Ferrario @.***> wrote:

This PR is becoming urgent, can the designated reviewers @.*** https://github.com/jmalbos and @gondiaz https://github.com/gondiaz) deal with it before the end of the week? Otherwise I would ask @gonzaponte https://github.com/gonzaponte to step in if he's available.

— Reply to this email directly, view it on GitHub https://github.com/next-exp/nexus/pull/164#issuecomment-1156472592, or unsubscribe https://github.com/notifications/unsubscribe-auth/AISTSDG235HXL674ZD4JZ53VPHK3VANCNFSM5UOKRY7A . You are receiving this because you were mentioned.Message ID: @.***>

jmalbos commented 2 years ago

This PR is becoming urgent, can the designated reviewers (@jmalbos and @gondiaz) deal with it before the end of the week? Otherwise I would ask @gonzaponte to step in if he's available.

I'll do it by Friday.