search

next-exp / nexus

Geant4 simulation framework of the NEXT Collaboration
5 stars 55 forks source link

Optical fibre2 #178

Closed FabianKellerer closed 10 months ago

FabianKellerer commented 2 years ago

Added the OpticalFibre geometry to perform studies with optical fibres. Added the GenericWLSFiber geometry to use in the NextFlex geometry as individual fibres.

paolafer commented 2 years ago

As a generic comment: try to include in one commit only changes logically related among them and write a comment that describes these changes. For instance, in commit 174ccc3 you create a new class, change the value of the reflectivity of a material and change the value of a parameter in a configuration file, but the the comment of the commit only refers to a bug in the event action (I guess it is related to the latter of the changes).

paolafer commented 2 years ago

I also think that commits 60690bf4ed6b4ac05d41e3856c746bca04518069 and 0bb89f381c2cb631f22cd9d0b9dbe3a17af87337 can be removed altogether, since the latter removes lines introduced in the former.

paolafer commented 2 years ago

Another general comment: if the comment of your commit exceeds the maximum number of characters, choose a shorter sentence in the first line and add more information in the following lines. I can show you how to do it, too.

paolafer commented 10 months ago

@FabianKellerer I guess that this PR can be deleted, right?

FabianKellerer commented 10 months ago

@FabianKellerer I guess that this PR can be deleted, right?

Yes! This was an earlier version of the GenericWLSfiber PR which is now merged, so we don't need this one anymore.