search

next-exp / nexus

Geant4 simulation framework of the NEXT Collaboration
5 stars 55 forks source link

Generic wls fiber #183

Closed FabianKellerer closed 1 year ago

FabianKellerer commented 2 years ago

Added the GenericWLSFiber geometry. Updated the MaterialsList to include the EJ-286 fiber core material.

soleti commented 1 year ago

Hello, I was wondering if there were any updates about this. If the code is fine it would be helpful for us working on fibers simulations to merge it.

paolafer commented 1 year ago

@jmalbos is the reviewer, how is it going, Justo?

jmalbos commented 1 year ago

@jmalbos is the reviewer, how is it going, Justo?

I'll try to finish the review asap, but, most likely, I won't be able till next week.

paolafer commented 1 year ago

Hi, everybody! How are we going with this PR? As far as I know, several people are using this geometry, without the code being approved, and I think it's not optimal. Could we move this forward? @jmalbos, @soleti?

paolafer commented 1 year ago

@FabianKellerer, how is this PR going?

FabianKellerer commented 1 year ago

Apart few small things, I don't see any obvious problem in the code (which I have been using for a while after all...). However, before merging, I think it would be nice to verify that we reproduce some fundamental properties of the WLS fibers. At least two plots might be added for completeness to this PR (maybe they already exist but I couldn't find them on DocDB):

* attenuation length: light collected as a function of the distance from a generic photosensor

* trapping efficiency: amount of light collected by generating photons at the center of the fiber.

This information can be found in the attached file. The trapping efficiency given by the manufacturer is reproduced very well, and the attenuation is aprrox. 60% per meter. Fibre Trapping Efficiencies.pdf

soleti commented 1 year ago

Thank you @FabianKellerer for the slides, very informative. The only remaining doubt I have is about the attenuation length. For e.g. Kuraray Y11 fibers that have an attenuation length of >3.5 m we should lose only ~25% of the light and not 60% after 1 m. Or am I misinterpreting your numbers? Thanks!

paolafer commented 1 year ago

@FabianKellerer, could you have a look at this last question from Roberto, so that we can approve the PR? Thanks!

FabianKellerer commented 1 year ago

Thank you @FabianKellerer for the slides, very informative. The only remaining doubt I have is about the attenuation length. For e.g. Kuraray Y11 fibers that have an attenuation length of >3.5 m we should lose only ~25% of the light and not 60% after 1 m. Or am I misinterpreting your numbers? Thanks!

I made a plot comparing light loss in the simulation to the light loss measured by Kuraray (Link) The agreement seems quite good. AttenuationLength

soleti commented 1 year ago

This looks good to me! I approve the PR.

paolafer commented 1 year ago

The code is not compiling!

paolafer commented 1 year ago

My compiler is also issuing the following compilation warning: source/geometries/GenericWLSFiber.cc:48:3: warning: field 'coating_optProp_' will be initialized after field 'core_mat_' [-Wreorder-ctor] coating_optProp_(nullptr).

To avoid this kind of warnings, it is a good rule to declare variables in the header file and to initialize them in the .cc file in the same order. Can you fix that, too?