search

next-exp / nexus

Geant4 simulation framework of the NEXT Collaboration
5 stars 55 forks source link

Clean base geometry #196

Closed paolafer closed 10 months ago

paolafer commented 1 year ago

This PR addresses issue #47 and eliminates the concept of EL z coordinate replacing it with the origin of coordinates, which is more general and can be used with any geometry, when it is not placed in (0, 0, 0). I have implemented the changes only for NEXT-100, for the moment, to receive feedback. If we consider this approach OK, the next steps would be to remove the setter/getter of ELzCoord from GeometryBase.h and do the same with the NEW and DEMO geometries. I would probably implement the changes only in DEMO, since NEW is soon to become obsolete; we could simply transfer the ELzCoord setter/getter to each NEW class that needs them. I would like to know @jmalbos and @jmunozv's opinions on this topic, plus anybody else's who wants to contribute.

paolafer commented 10 months ago

The commits of this PR have been added in PR #222. Since the NEXT-100 field cage is displaced from (0, 0, 0) in three coordinates, it is necessary to make these changes now. Since I haven't heard complaints since February, I assume that everybody agrees with the new implementation.