search

next-exp / nexus

Geant4 simulation framework of the NEXT Collaboration
5 stars 55 forks source link

Cigar #258

Closed MarcSeemann closed 2 months ago

paolafer commented 2 months ago

Hi @MarcSeemann! I've noticed that your branch is quite old (in fact, it doesn't compile with the last Geant4 version). I suggest you rebase it on master before we can go through a review.

MarcSeemann commented 2 months ago

Hey Dr. Paola Ferrario,Sorry I didn‘t mean to try and push to main. But yes, if I ever want to I will make sure it works with the latest version.Kind Regards,MarcAm 24.06.2024 um 11:37 schrieb Paola Ferrario @.***>: Hi @MarcSeemann! I've noticed that your branch is quite old (in fact, it doesn't compile with the last Geant4 version). I suggest you rebase it on master before we can go through a review.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

paolafer commented 2 months ago

Hey Dr. Paola Ferrario,Sorry I didn‘t mean to try and push to main. But yes, if I ever want to I will make sure it works with the latest version.Kind Regards>

It's just that for anyone to review your code properly, it needs to compile and it doesn't at the moment. I can hack it locally and make it compile for now, but you should rebase it, and the sooner the better.

paolafer commented 2 months ago

There are a lot of geometry overlaps in the code. Review each one of them, because they could bring to an unexpected behaviour in tracking.