next-theme / hexo-theme-next

🎉 Elegant and powerful theme for Hexo.
https://theme-next.js.org
Other
2.32k stars 416 forks source link

show tags on post-meta in excerpt mode #406

Closed zhaoyw1999 closed 2 years ago

zhaoyw1999 commented 2 years ago

PR Checklist

PR Type

What is the current behavior?

There is no tag on post-meta.

What is the new behavior?

How to use?

In NexT _config.yml:

post_meta:
  tags: true
welcome[bot] commented 2 years ago

Thanks so much for opening your first PR here!

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 1538900762


Totals Coverage Status
Change from base Build 1411888750: 0.0%
Covered Lines: 138
Relevant Lines: 141

💛 - Coveralls
stevenjoezhang commented 2 years ago

See also https://github.com/next-theme/hexo-theme-next/discussions/291

zhaoyw1999 commented 2 years ago

See also #291

Hi @stevenjoezhang

Thanks for your reply. I have just seen #291. What I want to confirm is:

Feel free to give some comments.

Looking forward to hearing from you. Thanks in advance.

stevenjoezhang commented 2 years ago

Thanks for your contribution, sorry for the late reply.

is it neccessary to provide a configuration option to control whether tags should be displayed in post-meta on the full-text page or the footer

The current behaviour of tags and categories are indeed different, but I don’t think it is necessary to add new options. Putting tags at the end of the post can be considered a feature of the theme

For i18n translation, you only need to modify the en.yml file, and crowdin bot will automatically synchronize translations in other languages

zhaoyw1999 commented 2 years ago

Hi @stevenjoezhang

Thanks for your comments. I have deleted all the i18n changes except English.

zhaoyw1999 commented 2 years ago

Hi @stevenjoezhang

Just noticed that the tag for v8.9.0 had been removed. Is there any update or actions required?

Looking forward to hearing from you. Thanks in advance.

ljcbaby commented 2 years ago

We are sorry, but we will reject this pull request.