fix nested export key - Githubissues

nextapps-de / flexsearch

Next-Generation full text search library for Browser and Node.js

Apache License 2.0

12.53k stars 491 forks source link

fix nested export key #275

Closed tiejunhu closed 2 years ago

tiejunhu commented 3 years ago

trying to fix issue #273

ts-thomas commented 3 years ago

Thanks for this PR. I will need some further investigation for this changes if this has no side-effects.

crutchcorn commented 2 years ago

@tiejunhu why was this PR closed? It seems that this fixes a big part of https://github.com/nextapps-de/flexsearch/issues/290

tiejunhu commented 2 years ago

@tiejunhu why was this PR closed? It seems that this fixes a big part of #290

Sorry I thought it's already merged. I'll reopen it.

canavci2016 commented 2 years ago

i have just seen the function you should do some enhancement on this function. it depends on many paramaters which lead to some misunderstandings and will be hard to maintain in the feature. therefore i left a link below i hope it might be helpful. Also i must say that the performance benchmark is amazing.

https://refactoring.guru/smells/long-parameter-list

ts-thomas commented 2 years ago

I will merge it and apply some little improvement on top of it.