Official providers All provider's logo is not proper showing

kr-nikunj commented 5 months ago

What is the improvement or update you wish to see?

According to the mode of the site, logo colors should change. If dark mode is enabled then the logo should be white and the same for the opposite.

some logos are not loaded properly

Is there any context that might help us understand?

No

Does the docs page already exist? Please link to it.

https://authjs.dev/getting-started/providers

github-actions[bot] commented 4 months ago

This issue was marked with the good first issue label by a maintainer.

This means that it is a good candidate for someone interested in contributing to the project, but does not know where to start.

Have a look at the Contributing Guide first.

This will help you set up your development environment to get started. When you are ready, open a PR, and link back to this issue in the form of adding Fixes #1234 to the PR description, where 1234 is the issue number. This will auto-close the issue when the PR gets merged, making it easier for us to keep track of what has been fixed.

Please make sure that - if applicable - you add tests for the changes you make.

If you have any questions, feel free to ask in the comments below or the PR. Generally, you don't need to @mention anyone directly, as we will get notified anyway and will respond as soon as we can)

[!NOTE]
There is no need to ask for permission "can I work on this?" Please, go ahead if there is no linked PR :slightly_smiling_face:

Farooq-Abdulla commented 2 months ago

is this issue still open ? if yes , how do i get to this file?

srpiroliro commented 2 months ago

is this issue still open ? if yes , how do i get to this file?

For now, the only thing I found is that the images are hosted on authjs.dev site (https://authjs.dev/img/providers/...), and https://authjs.dev/img/providers/google.svg gives the Google icon. About the dark style logos, no idea.

All of this was found inside of /node_modules/@auth/core/lib/pages/signin.js

Bisxsh commented 1 month ago

Dark style logos were removed in https://github.com/nextauthjs/next-auth/pull/10542 as they were sparsely used anyway, so the dark mode part of this issue is probably redundant now Haven't looked into the logo loading problem so can't speak on that

Jay-Karia commented 1 month ago

I think the page got updated and this issue should be closed

mabbasbangash97 commented 3 weeks ago

https://authjs.dev/getting-started/providers

The github and okta logos are still not resembling the theme.

Jay-Karia commented 3 weeks ago

Oh my bad 🙃, This is the file where the logos are rendered. And here are the logo files.

So updating the logo file might fix this!

Jay-Karia commented 3 weeks ago

Dark style logos were removed in #10542 as they were sparsely used anyway, so the dark mode part of this issue is probably redundant now Haven't looked into the logo loading problem so can't speak on that

@Bisxsh They have removed dark styled logos from the application, not from the docs (which is referred in this issue)

nextauthjs / next-auth