nextauthjs / next-auth

Authentication for the Web.
https://authjs.dev
ISC License
24.96k stars 3.52k forks source link

ProfileCallback with Azure AD provider gets stuck #10337

Closed bjoernwuest closed 8 months ago

bjoernwuest commented 8 months ago

Provider type

Azure Active Directory

Environment

System: OS: Windows 11 10.0.22621 CPU: (8) x64 Intel(R) Core(TM) i7-8565U CPU @ 1.80GHz Memory: 4.62 GB / 15.75 GB Binaries: Node: 21.6.2 - C:\Program Files\nodejs\node.EXE npm: 10.2.4 - C:\Program Files\nodejs\npm.CMD pnpm: 8.15.4 - ~\AppData\Local\pnpm\pnpm.EXE Browsers: Edge: Chromium (122.0.2365.80) Internet Explorer: 11.0.22621.1

Reproduction URL

none

Describe the issue

Application works until profile callback is added. Once profile callback is added, application get's stuck in authentication.

Relevant code snippet:

const authConfig = {
    providers: [AzureAd({
                    clientId: "myClientId",
                    clientSecret: "myClientSecret",
                    tenantId: "myTenantId",
/*                    profile: (profile: Profile, tokens: TokenSet): Promise<User> => {
                        return new Promise<User>(async () => {
                            const roles = (profile?.groups || []) as string[];
                            console.log("Roles of user", roles);
                            return {role:roles};
                        });
                    },*/
                })],
    debug: (process.env.AUTHJS_DEBUG === "true"),
    events: {
        signIn(message) {
            console.log("------------ signIn", message);
        }
    }
} satisfies NextAuthConfig;
export const { handlers, auth, signIn, signOut } = await NextAuth(authConfig);

The code above works, I can read the "signIn message" stuff. Yet, adding the profile callback (i.e. removing the comments), the console with just print "Roles of user ..." and then the application hangs. In the browser, the last call goes to "http://localhost:3000/api/auth/callback/azure-ad?code=..."

Since I have a very hard time to do step-by-step debugging (never got it working in TypeScript environment), I cannot give more details where it may hang, but this is annoying.

How to reproduce

Add provider callback to Azure AD provider.

Expected behavior

Roles to be read and authentication shall continue.

github-actions[bot] commented 8 months ago

We could not detect a valid reproduction link. Make sure to follow the bug report template carefully.

Why was this issue closed?

To be able to investigate, we need access to a reproduction to identify what triggered the issue. We need a link to a public GitHub repository. Example: (NextAuth.js example repository).

The bug template that you filled out has a section called "Reproduction URL", which is where you should provide the link to the reproduction.

What should I do?

Depending on the reason the issue was closed, you can do the following:

In general, assume that we should not go through a lengthy onboarding process at your company code only to be able to verify an issue.

My repository is private and cannot make it public

In most cases, a private repo will not be a sufficient minimal reproduction, as this codebase might contain a lot of unrelated parts that would make our investigation take longer. Please do not make it public. Instead, create a new repository using the templates above, adding the relevant code to reproduce the issue. Common things to look out for:

I did not open this issue, but it is relevant to me, what can I do to help?

Anyone experiencing the same issue is welcome to provide a minimal reproduction following the above steps by opening a new issue.

I think my reproduction is good enough, why aren't you looking into it quickly?

We look into every issue and monitor open issues for new comments.

However, sometimes we might miss a few due to the popularity/high traffic of the repository. We apologize, and kindly ask you to refrain from tagging core maintainers, as that will usually not result in increased priority.

Upvoting issues to show your interest will help us prioritize and address them as quickly as possible. That said, every issue is important to us, and if an issue gets closed by accident, we encourage you to open a new one linking to the old issue and we will look into it.

Useful Resources