nextauthjs / next-auth

Authentication for the Web.
https://authjs.dev
ISC License
25.07k stars 3.55k forks source link

Detect Origin Function is not configurable by the auth options which cause issues for multi tenancy across subdomains #10627

Closed thomasmillercf closed 7 months ago

thomasmillercf commented 7 months ago

Environment

Any

version 4.24.7

Reproduction URL

private

Describe the issue

I am trying to host a single nextauth server which is usable across multiple subdomains (ie a.app/api/auth/session & b.app/api/auth/session) however the catch being when you log in the redirect url is restricted to the next auth url which determined by the following function, when using a custom oauth client.

The following function is the reason for this behavior. utils/detect-origin.ts image

You can override this behaviour in the core/lib/oauth/authorization-url.ts with AuthorizationParamaters however its not possible to override in core/lib/oauth/callback.ts where the custom defined token parameters are ignored. Which means the IDP rejects the token exchange as the redirect url does not match the authorization call redurect url.

One way around this is to do something unspeakable which is to do override process.env.NEXTAUTH_URL = dynamicUrl in code 🤮. This then forces the detechOrigin function to use the custom url. Allow muti tenancy with a single server

The providers I am using already restrict the redirects and in my service i can trust the host. Where i can use the undocumented AUTH_TRUST_HOST env to enable this feature. This feature should be configurable by the auth options and documented.

What would be even better though is the NEXTAUTH_URL was not taken directly from environment variables but if the url was defined in next auth option use that instead. This would allow the url to be restricted to a domain, but dynamic for a subdomain.

Additional it would be great if there was some example or documents on how to do multitenancy with a single instance for a non vercel hosted app.

How to reproduce

Run a nextjs app with next auth. With configured NEXTAUTH_URL which is 'localhost:4200'

in the provider configure

go to x.localhost:4200/api/auth/signin

This will fail

Expected behavior

authOption = { ... hostTrusted: true ... }

Or allow dyanmic URL authOption = { ... url: ${dynamic}.localhost:4200/api/auth/signin ... }

github-actions[bot] commented 7 months ago

We could not detect a valid reproduction link. Make sure to follow the bug report template carefully.

Why was this issue closed?

To be able to investigate, we need access to a reproduction to identify what triggered the issue. We need a link to a public GitHub repository. Example: (NextAuth.js example repository).

The bug template that you filled out has a section called "Reproduction URL", which is where you should provide the link to the reproduction.

What should I do?

Depending on the reason the issue was closed, you can do the following:

In general, assume that we should not go through a lengthy onboarding process at your company code only to be able to verify an issue.

My repository is private and cannot make it public

In most cases, a private repo will not be a sufficient minimal reproduction, as this codebase might contain a lot of unrelated parts that would make our investigation take longer. Please do not make it public. Instead, create a new repository using the templates above, adding the relevant code to reproduce the issue. Common things to look out for:

I did not open this issue, but it is relevant to me, what can I do to help?

Anyone experiencing the same issue is welcome to provide a minimal reproduction following the above steps by opening a new issue.

I think my reproduction is good enough, why aren't you looking into it quickly?

We look into every issue and monitor open issues for new comments.

However, sometimes we might miss a few due to the popularity/high traffic of the repository. We apologize, and kindly ask you to refrain from tagging core maintainers, as that will usually not result in increased priority.

Upvoting issues to show your interest will help us prioritize and address them as quickly as possible. That said, every issue is important to us, and if an issue gets closed by accident, we encourage you to open a new one linking to the old issue and we will look into it.

Useful Resources