chore(sveltekit): update sveltekit eslint tooling

nextauthjs / next-auth

Authentication for the Web.

https://authjs.dev

ISC License

22.49k stars 2.98k forks source link

chore(sveltekit): update sveltekit eslint tooling #10748

Closed ndom91 closed 2 weeks ago

ndom91 commented 2 weeks ago

☕️ Reasoning

Update svelte eslint tooling from eslint-plugin-svelte3 to eslint-plugin-svelte (Source)
Added dist output folder to clean npm script in framework-sveltekit
Cleaned up a few small things like rm ignoring directories that no longer exist and removing unnecessary prettier overrides

I'd love someone with VSCode to test this as well though, looks good to me in nvim and build output is the same too

🧢 Checklist

[ ] Documentation
[ ] Tests
[ ] Ready to be merged

🎫 Affected issues

📌 Resources

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
auth-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 1, 2024 9:49am
proxy	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 1, 2024 9:49am

1 Ignored Deployment

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.12%. Comparing base (e6f90b2) to head (d260cba).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #10748 +/- ## ======================================= Coverage 41.12% 41.12% ======================================= Files 173 173 Lines 28472 28472 Branches 1179 1179 ======================================= Hits 11710 11710 Misses 16762 16762 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

socket-security[bot] commented 2 weeks ago

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

ndom91 commented 2 weeks ago

Should we also remove next-auth/packages/frameworks-sveltekit/.eslintrc.cjs, I think its not used right

Yeah I think you're right. I've removed them :+1:

ThangHuuVu commented 2 weeks ago

@ndom91 there is still one issue in the build, shall we fix it here too?

ndom91 commented 2 weeks ago

@ThangHuuVu yeah good eye - just ran prettier on it and pushed. Lets see

socket-security[bot] commented 2 weeks ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@actions/core@1.10.1	environment, filesystem Transitive: network	`+1`	149 kB	thboop
npm/@ariakit/react@0.4.5	None	`+2`	3.62 MB	ariakit-bot
npm/@auth/prisma-adapter@2.0.0	None	`0`	35.2 kB	balazsorban
npm/@auth/unstorage-adapter@2.0.0	None	`0`	37.5 kB	balazsorban
npm/@aws-sdk/client-dynamodb@3.499.0	Transitive: environment, filesystem, shell	`+28`	3.7 MB	aws-sdk-bot
npm/@aws-sdk/lib-dynamodb@3.499.0	None	`+1`	261 kB	aws-sdk-bot
npm/@azure/data-tables@13.2.2	Transitive: environment, network	`+9`	3.17 MB	azure-sdk

🚮 Removed packages: npm/@sveltejs/adapter-auto@3.2.0, npm/@sveltejs/kit@2.5.7, npm/@sveltejs/vite-plugin-svelte@3.1.0, npm/svelte-check@3.6.9, npm/svelte@4.2.15, npm/typescript@5.4.5, npm/vite@5.2.10

View full report↗︎