fix(core): support `trailingSlash` in `providerAndAccountId` parsing

nextauthjs / next-auth

Authentication for the Web.

https://authjs.dev

ISC License

22.48k stars 2.98k forks source link

fix(core): support `trailingSlash` in `providerAndAccountId` parsing #10752

Closed ndom91 closed 2 weeks ago

ndom91 commented 2 weeks ago

☕️ Reasoning

Support action / providerId paths with trailingSlash enabled (i.e. /api/auth/callback/google/)
Add three tests, one with default basePath one with custom basePath and one with edge-case multiple trailingSlashes

Fixes #10127

🧢 Checklist

[ ] Documentation
[ ] Tests
[ ] Ready to be merged

🎫 Affected issues

📌 Resources

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
auth-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 29, 2024 11:11am
proxy	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 29, 2024 11:11am

1 Ignored Deployment

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.46%. Comparing base (42ecf79) to head (1e8acb3).

:exclamation: Current head 1e8acb3 differs from pull request most recent head 01408bf. Consider uploading reports for the commit 01408bf to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #10752 +/- ## ======================================= Coverage 41.46% 41.46% ======================================= Files 172 172 Lines 28236 28236 Branches 1171 1171 ======================================= Hits 11709 11709 Misses 16527 16527 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.