nextauthjs / next-auth

Authentication for the Web.
https://authjs.dev
ISC License
22.88k stars 3.08k forks source link

[useSession] Calling update() does nothing when unauthenticated #10877

Closed william-will-angi closed 1 month ago

william-will-angi commented 1 month ago

Environment

  System:
    OS: macOS 14.4.1
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
    Memory: 160.42 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 14.18.2 - ~/.nvm/versions/node/v14.18.2/bin/node
    npm: 6.14.15 - ~/.nvm/versions/node/v14.18.2/bin/npm
  Browsers:
    Chrome: 124.0.6367.201
    Safari: 17.4.1
  npmPackages:
    next: 12.1.6 => 12.1.6 
    next-auth: ^4.24.5 => 4.24.5 
    react: 17.0.2 => 17.0.2 

Reproduction URL

N/A

Describe the issue

When calling the update function returned by useSession it doesn't actually do anything when the user is unauthenticated.

My expectation was that calling update should fire a request to /api/auth/session which would then re-hydrate the session provider with the latest information, but that doesn't seem to be the case.

How to reproduce

The following hook should reproduce the issue we're seeing:

import {useEffect} from 'react';
import {useSession} from 'next-auth/react';

const useMyHook = () => {
  const session = useSession()
  useEffect(()=>{
    if (session.status === 'unauthenticated') {
      session.update();
    }
  }, [session.status])
}

The above code will only call the /api/auth/session endpoint a single time.

Expected behavior

It's expected that the /api/auth/session endpoint would be called twice. The first time, behind the scenes by useSession to evaluate the session state and then a second time by the manual update to session.update()

github-actions[bot] commented 1 month ago

We could not detect a valid reproduction link. Make sure to follow the bug report template carefully.

Why was this issue closed?

To be able to investigate, we need access to a reproduction to identify what triggered the issue. We need a link to a public GitHub repository. Example: (NextAuth.js example repository).

The bug template that you filled out has a section called "Reproduction URL", which is where you should provide the link to the reproduction.

What should I do?

Depending on the reason the issue was closed, you can do the following:

In general, assume that we should not go through a lengthy onboarding process at your company code only to be able to verify an issue.

My repository is private and cannot make it public

In most cases, a private repo will not be a sufficient minimal reproduction, as this codebase might contain a lot of unrelated parts that would make our investigation take longer. Please do not make it public. Instead, create a new repository using the templates above, adding the relevant code to reproduce the issue. Common things to look out for:

I did not open this issue, but it is relevant to me, what can I do to help?

Anyone experiencing the same issue is welcome to provide a minimal reproduction following the above steps by opening a new issue.

I think my reproduction is good enough, why aren't you looking into it quickly?

We look into every issue and monitor open issues for new comments.

However, sometimes we might miss a few due to the popularity/high traffic of the repository. We apologize, and kindly ask you to refrain from tagging core maintainers, as that will usually not result in increased priority.

Upvoting issues to show your interest will help us prioritize and address them as quickly as possible. That said, every issue is important to us, and if an issue gets closed by accident, we encourage you to open a new one linking to the old issue and we will look into it.

Useful Resources