nextauthjs / next-auth

Authentication for the Web.
https://authjs.dev
ISC License
24.56k stars 3.45k forks source link

GitHub provider always chooses the first email #12062

Closed Gioee closed 2 hours ago

Gioee commented 2 hours ago

Provider type

GitHub

Environment

  System:
    OS: macOS 14.6.1
    CPU: (8) arm64 Apple M3
    Memory: 129.80 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.12.2 - /usr/local/bin/node
    npm: 10.8.1 - /usr/local/bin/npm
    bun: 1.1.12 - ~/.bun/bin/bun
    Watchman: 2024.08.19.00 - /opt/homebrew/bin/watchman
  Browsers:
    Chrome: 129.0.6668.89
    Safari: 17.6
  npmPackages:
    next: 12.1.0 => 12.1.0 
    react: 17.0.2 => 17.0.2 

Reproduction URL

it's a private repository

Describe the issue

https://github.com/nextauthjs/next-auth/blob/a7491dcb9355ff2d01fb8e9236636605e2090145/packages/core/src/providers/github.ts#L169

How to reproduce

Let's say a user has three email addresses: A, B, C.

The user signs up to a service using this library with his Google account that uses email A. Then after a few days the user tries to log in to the same service with a GitHub account that has email B, A and C. The service is going to make a new account since the email B hasn't been registered in the past. With this proposed modification it should log in with the email A that is in the GitHub account too.

Expected behavior

The library should search in the users database if one of the provided email addresses from GitHub has already done a sign up. Otherwise it should create a new account with the first email provided by GitHub. Right now it's doing the same thing but just with the first email address provided by GitHub.

github-actions[bot] commented 2 hours ago

We could not detect a valid reproduction link. Make sure to follow the bug report template carefully.

Why was this issue closed?

To be able to investigate, we need access to a reproduction to identify what triggered the issue. We need a link to a public GitHub repository. Example: (NextAuth.js example repository).

The bug template that you filled out has a section called "Reproduction URL", which is where you should provide the link to the reproduction.

What should I do?

Depending on the reason the issue was closed, you can do the following:

In general, assume that we should not go through a lengthy onboarding process at your company code only to be able to verify an issue.

My repository is private and cannot make it public

In most cases, a private repo will not be a sufficient minimal reproduction, as this codebase might contain a lot of unrelated parts that would make our investigation take longer. Please do not make it public. Instead, create a new repository using the templates above, adding the relevant code to reproduce the issue. Common things to look out for:

I did not open this issue, but it is relevant to me, what can I do to help?

Anyone experiencing the same issue is welcome to provide a minimal reproduction following the above steps by opening a new issue.

I think my reproduction is good enough, why aren't you looking into it quickly?

We look into every issue and monitor open issues for new comments.

However, sometimes we might miss a few due to the popularity/high traffic of the repository. We apologize, and kindly ask you to refrain from tagging core maintainers, as that will usually not result in increased priority.

Upvoting issues to show your interest will help us prioritize and address them as quickly as possible. That said, every issue is important to us, and if an issue gets closed by accident, we encourage you to open a new one linking to the old issue and we will look into it.

Useful Resources