Trust Host not working as expected

nextauthjs / next-auth

Authentication for the Web.

ISC License

25.01k stars 3.53k forks source link

Environment

  System:
    OS: macOS 15.1
    CPU: (10) arm64 Apple M1 Pro
    Memory: 63.30 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 21.6.2 - ~/.asdf/installs/nodejs/21.6.2/bin/node
    Yarn: 1.22.22 - ~/.asdf/installs/nodejs/21.6.2/bin/yarn
    npm: 10.9.0 - ~/Dev/reco-search-chatdpg-frontends/node_modules/.bin/npm
    pnpm: 9.0.0 - ~/.asdf/installs/nodejs/21.6.2/bin/pnpm
  Browsers:
    Chrome: 130.0.6723.92
    Safari: 18.1
  npmPackages:
    next: 15.0.1 => 15.0.1
    next-auth: 5.0.0-beta.25 => 5.0.0-beta.25
    react: npm:react@rc => 18.3.1

Note this is not the env I experiment this issue with, I run the application in a docker with alpine lts image from node.

Reproduction URL

Describe the issue

In auth.js beta, when setting up the AUTH_TRUST_HOST env variable, or setting up the trustHost config value in auth, we realized that the trust host was not taken into account by the config. When loging in and out of the server, we would be redirected to 0.0.0.0:3000 (that is the listening address of our docker)

However, when setting up this piece of code in the src/app/api/auth/[...nextauth]/route.ts :

import { NextRequest } from "next/server";

import { handlers } from "@/auth";
import { logger } from "@/utils/logging";

const reqWithTrustedOrigin = (req: NextRequest): NextRequest => {
  if (process.env.AUTH_TRUST_HOST !== "true") return req;
  const host = req.headers.get("x-forwarded-host");
  const proto = req.headers.get("x-forwarded-proto");
  if (!proto || !host) {
    logger.warn({ host, message: "Missing proto or host", proto });
    return req;
  }
  const envOrigin = `${proto}://${host}`;
  const { href, origin } = req.nextUrl;
  logger.info({ envOrigin, href, origin });
  return new NextRequest(href.replace(origin, envOrigin), req);
};

export const GET = (req: NextRequest) => {
  return handlers.GET(reqWithTrustedOrigin(req));
};

export const POST = (req: NextRequest) => {
  return handlers.POST(reqWithTrustedOrigin(req));
};

Then the redirect URI would be correct. We don't want to have to add the AUTH_URL as we need to be able to listen on different path and let the reverse proxy do it's magic.

How to reproduce

Configure auth js in docker with trustHost. Deploy it behing a reverse proxy, and try to login. When signIn would be called, the actual uri would be 0.0.0.0:3000 instead of host:443 as setup in the x-forwarded-proto x-forwarded-host http headers.

Expected behavior

We don't have to hack the handlers to be able to get the right behavior behind a reverse proxy

We could not detect a valid reproduction link. Make sure to follow the bug report template carefully.

Why was this issue closed?

To be able to investigate, we need access to a reproduction to identify what triggered the issue. We need a link to a public GitHub repository. Example: (NextAuth.js example repository).

The bug template that you filled out has a section called "Reproduction URL", which is where you should provide the link to the reproduction.

If you did not provide a link or the link you provided is not hosted on github.com outside of the next-auth organization, we will close the issue.
If you provide a link to a private repository, we will close the issue.
If you provide a link to a repository but not in the correct section, we will close the issue.

What should I do?

Depending on the reason the issue was closed, you can do the following:

If you did not provide a link hosted on github.com outside of the next-auth organization, please open a new issue with a link to such a reproduction.
If you provided a link to a private repository, please open a new issue with a link to a public repository.
If you provided a link to a repository but not in the correct section, please open a new issue with a link to a reproduction in the correct section.

In general, assume that we should not go through a lengthy onboarding process at your company code only to be able to verify an issue.

My repository is private and cannot make it public

In most cases, a private repo will not be a sufficient minimal reproduction, as this codebase might contain a lot of unrelated parts that would make our investigation take longer. Please do not make it public. Instead, create a new repository using the templates above, adding the relevant code to reproduce the issue. Common things to look out for:

Remove any code that is not related to the issue. (pages, API Routes, components, etc.)
Remove any dependencies that are not related to the issue.
Remove any third-party service that would require us to sign up for an account to reproduce the issue.
Remove any environment variables that are not related to the issue.
Remove private packages that we do not have access to.
If the issue is not related to a monorepo specifically, try to reproduce the issue without a complex monorepo setup

I did not open this issue, but it is relevant to me, what can I do to help?

Anyone experiencing the same issue is welcome to provide a minimal reproduction following the above steps by opening a new issue.

I think my reproduction is good enough, why aren't you looking into it quickly?

We look into every issue and monitor open issues for new comments.

However, sometimes we might miss a few due to the popularity/high traffic of the repository. We apologize, and kindly ask you to refrain from tagging core maintainers, as that will usually not result in increased priority.

Upvoting issues to show your interest will help us prioritize and address them as quickly as possible. That said, every issue is important to us, and if an issue gets closed by accident, we encourage you to open a new one linking to the old issue and we will look into it.

nextauthjs / next-auth