search

nextauthjs / next-auth

Authentication for the Web.
https://authjs.dev
ISC License
23.78k stars 3.27k forks source link

Not being able to use PKCE key for Azure AD login #8690

Closed GabrielChedaVia closed 10 months ago

GabrielChedaVia commented 10 months ago

Environment

All the lastest versions of NextJS and next auth

Reproduction URL

I don't have a repository

Describe the issue

When I try to login using Azure AD it's not saving the PKCE verifier in cookies even if I set the cookie options. Can someone please help? :D

Next Auth Config:

`const code_verifier = base64url(crypto.pseudoRandomBytes(32)); function createCodeChallenge() { const hash = crypto .createHash("sha256") .update(codeverifier) .digest("base64"); return hash.replace(/+/g, "-").replace(/\//g, "").replace(/=+$/, ""); }

const authOptions: AuthOptions = { providers: [ AzureADProvider({ clientId: process.env.AZURE_AD_CLIENT_ID!, clientSecret: process.env.AZURE_AD_CLIENT_SECRET!, tenantId: process.env.AZURE_AD_TENANT_ID!, // idToken: true, authorization: { params: { response_mode: "query", scope: api://${process.env.AZURE_AD_CLIENT_ID}/Api.Auth, redirect_uri: "http://localhost:3000/login", client_id: process.env.AZURE_AD_CLIENT_ID!, code_challenge: createCodeChallenge(), code_challenge_method: "S256", }, }, }), ], pages: { signIn: "/", }, }; export default NextAuth(authOptions); `

Trying to generate ID TOKEN:

export default function LoginPage() { const params = useSearchParams(); const requestUrl =https://login.microsoftonline.com/${AZURE_AD_TENANT_ID}/oauth2/v2.0/token`; const code = params?.get("code");

if (code) { const formData = new URLSearchParams({ client_id: AZURE_AD_CLIENT_ID as string, scope: encodeURI(api://${AZURE_AD_CLIENT_ID}/Api.Auth), code: code, redirect_uri: encodeURI("http://localhost:3000/login"), code_verifier: ** here is the problem, Im not able to get code_verifier from cookies ***, grant_type: "authorization_code", });

fetch(
  `https://login.microsoftonline.com/${AZURE_AD_TENANT_ID}/oauth2/v2.0/token`,
  {
    method: "POST",
    body: formData,
    headers: {
      "Content-Type": "application/x-www-form-urlencoded",
    },
  }
)
  .then(async (x) => {
    const response = await x.json();
    console.log("OK!!", response);
  })
  .catch((x) => {
    console.log("err!!", x);
  });

}

return <></>; } `

How to reproduce

Copy and paste the code :D

Expected behavior

Find the cookie for pkce

github-actions[bot] commented 10 months ago

We could not detect a valid reproduction link. Make sure to follow the bug report template carefully.

Why was this issue closed?

To be able to investigate, we need access to a reproduction to identify what triggered the issue. We need a link to a public GitHub repository. Example: (NextAuth.js example repository).

The bug template that you filled out has a section called "Reproduction URL", which is where you should provide the link to the reproduction.

What should I do?

Depending on the reason the issue was closed, you can do the following:

In general, assume that we should not go through a lengthy onboarding process at your company code only to be able to verify an issue.

My repository is private and cannot make it public

In most cases, a private repo will not be a sufficient minimal reproduction, as this codebase might contain a lot of unrelated parts that would make our investigation take longer. Please do not make it public. Instead, create a new repository using the templates above, adding the relevant code to reproduce the issue. Common things to look out for:

I did not open this issue, but it is relevant to me, what can I do to help?

Anyone experiencing the same issue is welcome to provide a minimal reproduction following the above steps by opening a new issue.

I think my reproduction is good enough, why aren't you looking into it quickly?

We look into every issue and monitor open issues for new comments.

However, sometimes we might miss a few due to the popularity/high traffic of the repository. We apologize, and kindly ask you to refrain from tagging core maintainers, as that will usually not result in increased priority.

Upvoting issues to show your interest will help us prioritize and address them as quickly as possible. That said, every issue is important to us, and if an issue gets closed by accident, we encourage you to open a new one linking to the old issue and we will look into it.

Useful Resources